London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | Implement-and-rewrire-tests - #1612
Open
mandipsanger wants to merge 9 commits into
Open
London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | Implement-and-rewrire-tests#1612mandipsanger wants to merge 9 commits into
mandipsanger wants to merge 9 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
mandipsanger
changed the title
This comment has been minimized.
This comment has been minimized.
mandipsanger
changed the title
mandipsanger
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Sep 14, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Almost there, just a couple of small comments to fix
| }); | ||
|
|
||
| test("should return false when both numerator and denominator are negative", () => { | ||
| expect(isProperFraction(-4, -5)).toEqual(false); |
There was a problem hiding this comment.
I think this isn't quite right. I maths, a fraction is proper when the value of the numerator, ignoring the ± sign, is smaller than the fraction. So in this case, -4/-5 is true.
| } | ||
|
|
||
| if ( | ||
| rank === "2" || |
There was a problem hiding this comment.
This seems pretty complex, is there a way you could simplify checking these numbers?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1059
Changelist
Sprint 3 coursework